Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #579

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Develop #579

wants to merge 7 commits into from

Conversation

iirk1
Copy link

@iirk1 iirk1 commented Oct 31, 2024 

[DEMO LINK](https://iirk1.github.io/Museum/).

SanyaBratashchuk
SanyaBratashchuk suggested changes Oct 31, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. reset form after submit

anastasiiavorobiova
anastasiiavorobiova suggested changes Nov 1, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2024-11-01 at 17 08 46
  • These links should lead to the blank tab with the proper social media page
  • Screenshot 2024-11-01 at 17 08 36
  • Consider using links here (mailto, tel, Google Maps) Also, consider adding hover styles for interactive elements
  • Screenshot 2024-11-01 at 17 07 41
  • Screenshot 2024-11-01 at 17 07 45
  • Check the background for the button
  • Screenshot 2024-11-01 at 17 06 58
  • Consider adding hover styles here

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Nov 3, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iirk1 @VitaliyBondarenko1982 @SanyaBratashchuk @anastasiiavorobiova