Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #587

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Develop #587

wants to merge 7 commits into from

Conversation

MOODDDII
Copy link

@MOODDDII MOODDDII commented Nov 29, 2024 •
edited
Loading

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 30, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add hover effects for all clickable elements
image
  1. The input should stretch to the full width and height
image
  1. Need to fix the mobile version
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Nov 30, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-11-30 at 16 52 43
Screenshot 2024-11-30 at 16 52 49
Check the layout for this section for tablets and mobiles
Screenshot 2024-11-30 at 16 52 15
Screenshot 2024-11-30 at 16 52 22
Check the layout here

volodymyr-soltys97
volodymyr-soltys97 suggested changes Dec 2, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Remove this div wrapper
image
  1. Change the autofill styles for input
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Add hover effects here
image
  1. The tablet version looks strange, you need to fix it
image

etojeDenys
etojeDenys approved these changes Dec 2, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. disable the scroll if the menu is open
image
  1. looks good in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MOODDDII @volodymyr-soltys97 @etojeDenys @anastasiiavorobiova