Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #597

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

solution #597

wants to merge 4 commits into from

Conversation

hrnvam
Copy link

@hrnvam hrnvam commented Dec 29, 2024

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Add the topical title on the page
image
  1. Add hover effects for images
image
  1. Add cursor pointer and hover effects for this button
image
  1. This additional link should be open in the new tab
image
  1. Fix background color for the menu, and remove scroll when menu is open
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to fix all comments from the previous review. If you need some help feel free in the fe_chat

@hrnvam hrnvam closed this Dec 31, 2024
@hrnvam hrnvam deleted the develop branch December 31, 2024 08:14
@hrnvam hrnvam restored the develop branch December 31, 2024 08:16
@hrnvam hrnvam reopened this Dec 31, 2024
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants