Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution for Museum_2 #330

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Solution for Museum_2 #330

wants to merge 23 commits into from

Conversation

PaulMaistrenko
Copy link

etojeDenys
etojeDenys suggested changes Aug 31, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the photo overlapped the text on hover, let's fix that
image
  1. let's add some container with max-width to avoid this strange behaviour on the big screen
image
  1. it should be a links
image
  1. let's add smooth scroll

@PaulMaistrenko
Copy link
Author

fixed

etojeDenys
etojeDenys approved these changes Sep 4, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulMaistrenko @etojeDenys