Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #334

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Develop #334

wants to merge 11 commits into from

Conversation

ydem1
Copy link

@ydem1 ydem1 commented Sep 11, 2023

maxim2310
maxim2310 suggested changes Sep 11, 2023
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just one tiny thing needs to be fixed before approval)

would be nice to add more visible hover effect
image

@ydem1 ydem1 requested a review from maxim2310 September 11, 2023 19:52
etojeDenys
etojeDenys suggested changes Sep 12, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the header and menu heights should be 100vh

Screen.Recording.2023-09-12.at.09.28.45.mov
  1. and let's import all icons as svg it will improve at least the quality
image

@ydem1 ydem1 requested a review from etojeDenys September 12, 2023 06:48
maxim2310
maxim2310 suggested changes Sep 12, 2023
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you forgot to deploy your last changes because now first block isn't 100vh height
image

@ydem1 ydem1 requested a review from maxim2310 September 12, 2023 07:28
etojeDenys
etojeDenys approved these changes Sep 12, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should place this photo at the bottom of the menu
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@maxim2310 maxim2310 Awaiting requested review from maxim2310

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydem1 @etojeDenys @maxim2310