Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #338

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

NataliaDavida
Copy link

Copy link

@DarkMistyRoom DarkMistyRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! But here are some comments:

  • the logo should be a link to the main page
image
  • make the cursor a pointer over buttons

  • use select here

image
  • it should be a link to google maps
image
  • add hove effects to the links
image
  • add hover effects to all images
  • 'email' text should be a placeholder
image
  • clear the form on submit
  • the contacts should be links
image
  • these should be links to real socials. And add hover effects
image
  • add hover effects to all links in the footer
  • fix the overlapping (mobile)
image
  • add scroll to the menu to make it work fine in landscape mode
image

Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

To improve:

  1. add a favicon

  2. no needs to add scroll when you click at logo. Just use href="#"

  3. remove default autocomplete styles

Screenshot 2023-09-21 at 21 00 16
  1. update indents between section links
Screenshot 2023-09-21 at 21 02 28
  1. change order of icons
Screenshot 2023-09-21 at 21 03 53

Copy link
Contributor

@mykhalenych mykhalenych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2023-09-22.at.16.38.09.mov

and change autocomplete style for input

Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something with your DEMO link :(
Could you fix it?
image

@NataliaDavida
Copy link
Author

Something with your DEMO link :( Could you fix it? image

No :(

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to ask in chat for some help with it

Copy link

@andriy-shymkiv andriy-shymkiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants