Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Museum landing page #456

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add Museum landing page #456

wants to merge 4 commits into from

Conversation

yullitv
Copy link

@yullitv yullitv commented Aug 17, 2024

GUSILLUS
GUSILLUS suggested changes Aug 17, 2024
View reviewed changes
Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Consider adding some functionality or remove the button
image

Add hover
image

Add hover on links
image

@yullitv yullitv requested a review from GUSILLUS August 17, 2024 11:37
GUSILLUS
GUSILLUS suggested changes Aug 17, 2024
View reviewed changes
Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mail need to be a a tag
image

@yullitv yullitv requested a review from GUSILLUS August 17, 2024 11:53
GUSILLUS
GUSILLUS suggested changes Aug 17, 2024
View reviewed changes
Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

  1. Consider fixing padding on a tablet and phone
    image

  2. Back to top button open new tab instead of scroll
    image

@yullitv yullitv requested a review from GUSILLUS August 17, 2024 12:51
TarasHoliuk
TarasHoliuk approved these changes Aug 18, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarasHoliuk TarasHoliuk TarasHoliuk approved these changes

@GUSILLUS GUSILLUS Awaiting requested review from GUSILLUS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yullitv @TarasHoliuk @GUSILLUS