landing page #459
Open
landing page #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkruz
suggested changes
Sep 16, 2024
There was a problem hiding this comment.
LGTM 👍
watch the attached video and fix the changing width page when opening the menu
https://www.loom.com/share/2ca3af8ecf7442eba9ae3c8463b73fdd?sid=20f32e67-f05e-4f56-9074-fc85d291be5b
src/index.html
Outdated
Comment on lines
40
to
43
| <a | ||
| href="#menu" | ||
| class="icon icon--menu top-bar__icon" | ||
| ></a> |
There was a problem hiding this comment.
you can add aria-label to icons for better screen reader support.
Suggested change
| <a | |
| href="#menu" | |
| class="icon icon--menu top-bar__icon" | |
| ></a> | |
| <a | |
| href="#menu" | |
| class="icon icon--menu top-bar__icon" | |
| aria-label="Open menu" | |
| ></a> |
| <div class="language language--header top-bar__language"> | ||
| <select | ||
| required="required" | ||
| class="language__select" |
There was a problem hiding this comment.
you can also add the aria-label attribute here to improve accessibility.
src/index.html
Outdated
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#exibitions" |
There was a problem hiding this comment.
Suggested change
| href="#exibitions" | |
| href="#exhibitions" |
src/index.html
Outdated
Comment on lines
70
to
75
| <a | ||
| href="#plan-visit" | ||
| class="primary-button header__button" | ||
| > | ||
| Купити квиток | ||
| </a> |
There was a problem hiding this comment.
<a> tags used as buttons should include role="button" to ensure better screen reader support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK