Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add museum #470

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add museum #470

wants to merge 4 commits into from

Conversation

DmytroPAvlichenko
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 4, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the demo link is wrong now, you need to fix it and update if in the PR description
image

README.md Outdated
@@ -31,7 +31,7 @@ Check font styles. Use [Playfair Display](https://fonts.google.com/specimen/Play
11. `git push origin develop` - to send you code for PR.
12. Create a Pull Request (PR) from your branch `develop` to branch `master` of original repo.
13. Replace `<your_account>` with your Github username in the
[DEMO LINK](https://<your_account>.github.io/Museum_2/).
[DEMO LINK](https://DmytroPAvlichenko/.github.io/Museum_2/).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[DEMO LINK](https://DmytroPAvlichenko/.github.io/Museum_2/).
[DEMO LINK](https://DmytroPAvlichenko.github.io/Museum_2/).

Copy link

@TarasHoliuk TarasHoliuk Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, link in PR description is still not working: https://dmytropavlichenko/.github.io/Museum_2/

@TarasHoliuk
Copy link

  1. Remove the default border from the button:

image

  1. The page background should be white, the same as the button background:

image

  1. It should be working link:
    image

  2. For logos and icons use SVG images (export SVG from figma) for better quality:
    image

  3. Add a hover effect to links, and open external links in the new tab:
    image

  4. Add hover effect to images

  5. Buttons (and input) should always be full-width on the mobile version:
    image

TarasHoliuk
TarasHoliuk suggested changes Nov 4, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍 But a few things should be fixed/improved

etojeDenys
etojeDenys suggested changes Nov 4, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your demo link doesn't work, try to fix that

@DmytroPAvlichenko
Copy link
Author

Ваша демо-ссылка не работает, формат это исправить

your demo link doesn't work, try to fix that

https://DmytroPAvlichenko.github.io/Museum_2/

works for me

etojeDenys
etojeDenys approved these changes Nov 4, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DmytroPAvlichenko @TarasHoliuk @volodymyr-soltys97 @etojeDenys