Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit #473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

initial commit #473

wants to merge 3 commits into from

Conversation

jooaasss
Copy link

@jooaasss jooaasss commented Nov 6, 2024

@jooaasss
Copy link
Author

jooaasss commented Nov 6, 2024 •
edited
Loading

Good day, is translation required?

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 7, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add hover effects for all images
image
  1. These elements must be links and add hover effects here
image
  1. Don't need to use fixed width for the content, use width: 100% instead
image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 7, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. All this address must be link, the city name too. Also, you need to open this additional link in the new tab
image

volodymyr-soltys97
volodymyr-soltys97 approved these changes Nov 7, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jooaasss @volodymyr-soltys97