Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Museum 2 #474

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Museum 2 #474

wants to merge 5 commits into from

Conversation

Vl-Tsr
Copy link

@Vl-Tsr Vl-Tsr commented Nov 21, 2024

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 21, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add a favicon on the page
image
  1. Add hover effects for all clickable elements
image
  1. Fix the background image position, check it on the design
image image

etojeDenys
etojeDenys approved these changes Nov 21, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. stretch the menu height to be 100vh
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vl-Tsr @volodymyr-soltys97 @etojeDenys