Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #478

Closed
wants to merge 3 commits into from
Closed

Develop #478

wants to merge 3 commits into from

Conversation

AlinaYamchuk
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 25, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Need to disable scroll when the menu is open
image
  1. Check gap between these elements
image
  1. Add a better favicon on the page
image

  1. Add scroll behavior smooth on the page

  2. Change the autofill styles for the input

image
  1. Open thess additional links in the new tab
image image
  1. Add hover effects for all clickable elements
image

etojeDenys
etojeDenys suggested changes Nov 27, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. set 100vh height to the menu
  2. disabled scrolling if the menu opened
image
  1. add hovers to these links
  2. and open the address link in a new tab
image
  1. fix and remove that space
image
  1. same here
image
  1. looks broken
image
  1. feel free to ask for some help in the chat

@AlinaYamchuk AlinaYamchuk deleted the develop branch December 3, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys requested changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlinaYamchuk @volodymyr-soltys97 @etojeDenys