Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #483

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #483

wants to merge 6 commits into from

Conversation

AlinaYamchuk
Copy link

VitaliyBondarenko1982
VitaliyBondarenko1982 suggested changes Dec 4, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Suggest to limit max width for page content.
Screenshot 2024-12-04 at 15 25 14

Images should have distanct between each other according to design.
Screenshot 2024-12-04 at 15 25 00
Screenshot 2024-12-04 at 15 25 08

etojeDenys
etojeDenys suggested changes Dec 6, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

you should fix this strange behavior on tablet and mobile

anastasiiavorobiova
anastasiiavorobiova suggested changes Dec 7, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2024-12-07 at 15 19 15
  • There is a horizontal scroll on tablets and mobiles
  • Screenshot 2024-12-07 at 15 18 14
  • The image is cropped on desktops
  • Screenshot 2024-12-07 at 15 17 26
  • There is a white space on desktops
  • Screenshot 2024-12-07 at 15 17 02
  • Consider adding a required attribute for the input and clearing the form on the submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova requested changes

@VitaliyBondarenko1982 VitaliyBondarenko1982 Awaiting requested review from VitaliyBondarenko1982

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlinaYamchuk @VitaliyBondarenko1982 @etojeDenys @anastasiiavorobiova