Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Museum 2 landing #493

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Museum 2 landing #493

wants to merge 8 commits into from

Conversation

Dariya-Goncharovskaya
Copy link

etojeDenys
etojeDenys suggested changes Jan 29, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. should it have so big height?
image
  1. image must be tied to the bottom
image image

anastasiiavorobiova
anastasiiavorobiova suggested changes Jan 31, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2025-01-31 at 12 19 21
  • Consider clearing the form on the submit
  • Screenshot 2025-01-31 at 12 18 53
  • The menu opens and closes on the language button click

anastasiiavorobiova
anastasiiavorobiova approved these changes Jan 31, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dariya-Goncharovskaya @etojeDenys @anastasiiavorobiova