Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1094

Closed
wants to merge 17 commits into from
Closed

Develop #1094

wants to merge 17 commits into from

Conversation

taniakolesnik
Copy link

DEMO LINK
Please note that some test fails as added random new cells cannot make test pass.

  • should have a state with two cells with values 2 or 4 - UI all good. Can you please advise?
  • should generate 4 less often than 2 and should generate the board with cells in random positions - can you please advise about these ones?
  • if the move does not change the board - my game does not have state like this.

etojeDenys
etojeDenys suggested changes Dec 25, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restart button works strange

Screen.Recording.2024-12-25.at.19.07.52.mov
  1. you don't need to add a new cell if the board didn't change
Screen.Recording.2024-12-25.at.19.09.32.mov

@taniakolesnik taniakolesnik deleted the develop branch December 25, 2024 19:18
@taniakolesnik taniakolesnik restored the develop branch December 25, 2024 19:18
This was referenced Dec 25, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taniakolesnik @etojeDenys