Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests are added #625

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tests are added #625

wants to merge 2 commits into from

Conversation

KseniiaKrytska
Copy link

No description provided.

Kseniia Krytska added 2 commits November 24, 2024 14:46
Viktoriia-V-V
Viktoriia-V-V approved these changes Nov 24, 2024
View reviewed changes
Copy link

@Viktoriia-V-V Viktoriia-V-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good. I would remove two tests (for negative values and for thousands). But it is a good job

src/getHumanAge.test.js
test('should return both 0 for both minus numbers', () => {
expect(getHumanAge(-1, -1)).toEqual([0, 0]);
});

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not use negative values

src/getHumanAge.test.js
expect(getHumanAge(99, 104)).toEqual([20, 18]);
});

test('should work correct with thousands', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no need to check thousands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viktoriia-V-V Viktoriia-V-V Viktoriia-V-V approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KseniiaKrytska @Viktoriia-V-V