Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solution #628

wants to merge 1 commit into from

Conversation

Galers
Copy link

@Galers Galers commented Dec 9, 2024

Have a nice day!

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the getHumanAge function and its tests! 🎉 The logic is sound, and the test coverage is comprehensive. While there's a minor inconsistency with handling string inputs, it doesn't impact the core functionality. Keep up the good work, and consider refining how string inputs are managed in the future. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

});

test("should correctly handle invalid types", () => {
expect(getHumanAge("15", 15)).toEqual([1, 1]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case expect(getHumanAge("15", 15)).toEqual([1, 1]); assumes that a string input should be converted to a number. However, this behavior is not defined in the getHumanAge function, and typically, string inputs should result in an error or NaN. Consider updating the function to handle string inputs explicitly or adjust the test case to expect NaN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants