Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d #629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

d #629

wants to merge 1 commit into from

Conversation

Stepan-R
Copy link

@Stepan-R Stepan-R commented Dec 9, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the getHumanAge function! 🎉 The code meets the task requirements and constraints, and the tests are well-implemented. Just make sure to update the test descriptions to accurately reflect the expected outcomes. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +15 to +17
test('should return [0, 0] for ages 14, 14', () => {
expect(getHumanAge(14, 14)).toEqual([0, 0]);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description 'should return [0, 0] for ages 14, 14' is correct as per the task requirements, and the expected output [0, 0] is also correct.

Comment on lines +19 to +21
test('should return [0, 0] for ages 15, 15', () => {
expect(getHumanAge(15, 15)).toEqual([1, 1]);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description 'should return [0, 0] for ages 15, 15' is incorrect. It should be 'should return [1, 1] for ages 15, 15' to match the expected output [1, 1].

Comment on lines +23 to +25
test('should return [0, 0] for ages 24, 24', () => {
expect(getHumanAge(24, 24)).toEqual([2, 2]);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description 'should return [0, 0] for ages 24, 24' is incorrect. It should be 'should return [2, 2] for ages 24, 24' to match the expected output [2, 2].

Comment on lines +27 to +29
test('should return [0, 0] for ages 28, 28', () => {
expect(getHumanAge(28, 28)).toEqual([3, 2]);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description 'should return [0, 0] for ages 28, 28' is incorrect. It should be 'should return [3, 2] for ages 28, 28' to match the expected output [3, 2].

Comment on lines +31 to +33
test('should return [0, 0] for ages 100, 100', () => {
expect(getHumanAge(100, 100)).toEqual([21, 17]);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description 'should return [0, 0] for ages 100, 100' is incorrect. It should be 'should return [21, 17] for ages 100, 100' to match the expected output [21, 17].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants