Solution #1940
Open
Solution #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUSILLUS
suggested changes
Apr 25, 2024
src/formatDate.js
Outdated
Comment on lines
18
to
24
| if (component === 'YYYY') { | ||
| year = value; | ||
| } | ||
|
|
||
| if (component === 'YY') { | ||
| year = value; | ||
| } |
There was a problem hiding this comment.
Consider combining this in one if using || operator
src/formatDate.js
Outdated
Comment on lines
52
to
58
| if (component === 'YYYY') { | ||
| newDate.push(year); | ||
| } | ||
|
|
||
| if (component === 'YY') { | ||
| newDate.push(year); | ||
| } |
etojeDenys
approved these changes
Apr 26, 2024
Comment on lines
+48
to
+58
| if (component === 'YYYY' || component === 'YY') { | ||
| newDate.push(year); | ||
| } | ||
|
|
||
| if (component === 'MM') { | ||
| newDate.push(month); | ||
| } | ||
|
|
||
| if (component === 'DD') { | ||
| newDate.push(day); | ||
| } |
There was a problem hiding this comment.
better to simplify it using the switch/case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.