Test #2174
Test #2174
Conversation
There was a problem hiding this comment.
Your implementation of the formatDate function is on the right track and meets the core requirements of the task. 🎉 While there are some minor issues like variable naming and typos in comments, these don't impact the functionality. However, consider reviewing the logic for determining the century, as it might not be universally applicable. Keep up the good work and continue refining your code for clarity and maintainability! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| const joinSeparator = toFormat[toFormat.length - 1]; | ||
|
|
||
| // variables of index date fromFormate |
There was a problem hiding this comment.
The comment here has a typo: 'fromFormate' should be 'fromFormat'.
| const fromMM = fromFormat.indexOf('MM'); | ||
| const fromDD = fromFormat.indexOf('DD'); | ||
|
|
||
| // variables of index date toFormate |
There was a problem hiding this comment.
The comment here has a typo: 'toFormate' should be 'toFormat'.
| const toDD = toFormat.indexOf('DD'); | ||
|
|
||
| if (fromFormat[fromYYYY].length > toFormat[toYYYY].length) { | ||
| splitDate[fromYYYY] = splitDate[fromYYYY].slice(2); |
There was a problem hiding this comment.
This line slices the year to two digits if the 'fromFormat' year is longer than the 'toFormat' year. Ensure that this logic aligns with the expected behavior, especially if the formats might not always be 'YY' or 'YYYY'.
| if (+splitDate[fromYYYY] < 30) { | ||
| splitDate[fromYYYY] = '20' + splitDate[fromYYYY]; | ||
| } else { | ||
| splitDate[fromYYYY] = '19' + splitDate[fromYYYY]; |
There was a problem hiding this comment.
The logic for determining the century ('20' or '19') based on the year being less than 30 might not be universally applicable. Consider whether this assumption holds true for all expected input dates.
No description provided.