solution #2178
solution #2178
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 While there are some assumptions in your code regarding the separator and the order of date components, these do not critically impact the functionality for the given task requirements. In future projects, consider adding error handling and making your code more flexible to handle different formats dynamically. Keep up the good work and continue to refine your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| const separatorFrom = fromFormat[3]; | ||
| const separatorTo = toFormat[3]; |
There was a problem hiding this comment.
The assumption that the separator is always at index 3 in both fromFormat and toFormat arrays may not be correct. You should determine the separator dynamically or ensure that the format arrays are structured to include the separator explicitly.
| const newFormat = []; | ||
| const separatorFrom = fromFormat[3]; | ||
| const separatorTo = toFormat[3]; | ||
| const numbers = date.split(separatorFrom); |
There was a problem hiding this comment.
The split method assumes that the separator is correct and present in the date string. Consider adding error handling to manage cases where the separator is incorrect or missing.
| const separatorFrom = fromFormat[3]; | ||
| const separatorTo = toFormat[3]; | ||
| const numbers = date.split(separatorFrom); | ||
| let [year, month, day] = numbers; |
There was a problem hiding this comment.
The initial assignment of year, month, and day assumes a specific order in the numbers array. This may not be correct if the fromFormat is different. Ensure that the assignment matches the fromFormat specification.
No description provided.