Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added initial solution #2676

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

added initial solution #2676

Changes from 12 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
efa2ecd
added initial solution
vkryvytskyy Apr 3, 2024
a946d53
solution 2
vkryvytskyy Apr 4, 2024
6831bb9
solution 3
vkryvytskyy Apr 5, 2024
0c9c947
solution 4
vkryvytskyy Apr 5, 2024
b67f7e2
solution 5
vkryvytskyy Apr 5, 2024
66f7d93
solution 6
vkryvytskyy Apr 8, 2024
412eb24
solution 7
vkryvytskyy Apr 8, 2024
2c949bd
solution 8
vkryvytskyy Apr 8, 2024
07d32d3
solution 9
vkryvytskyy Apr 8, 2024
727503c
solution 10
vkryvytskyy Apr 8, 2024
a44140d
solution 9.2
vkryvytskyy Apr 9, 2024
6320c61
solution 8.2
vkryvytskyy Apr 9, 2024
b589d37
top solution
vkryvytskyy Apr 15, 2024
408ab78
top solution fixed
vkryvytskyy Apr 15, 2024
fc864ed
top solution fixed 2
vkryvytskyy Apr 15, 2024
297f3ed
top solution fixed 3
vkryvytskyy Apr 15, 2024
c1b5609
top solution fixed 4
vkryvytskyy Apr 15, 2024
0d59f06
new solution
vkryvytskyy Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/inverseRobot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,27 @@

function inverseRobot(robot) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a function description using JSDoc comments. This helps other developers understand what the function does, its parameters, and its return value.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a brief comment describing what your function does. This will help other developers understand your code more easily.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check to ensure that the 'robot' parameter is indeed an object and not null or undefined. This can prevent potential runtime errors if the function is called with invalid arguments.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function 'inverseRobot' is correctly named and describes its purpose well.

// write code here
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need inverse variable? You can use the return value.

let tempKyesRobot = {};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'tempKyesRobot' seems to be a typo. Consider renaming it to 'tempKeysRobot' for better readability.

let tempValueRobot = {};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'tempValueRobot' could be more descriptive. Consider renaming it to 'robotValues'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable names 'tempKyesRobot' and 'tempValueRobot' contain typos and are not descriptive of their purpose. Consider renaming them to 'robotKeys' and 'robotValues' respectively for clarity.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable names tempKyesRobot and tempValueRobot contain typos and are not descriptive of their purpose. Consider renaming them to robotKeys and robotValues respectively for clarity.


tempKyesRobot = Object.keys(robot);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to declare 'tempKyesRobot' as an empty object and then assign it with 'Object.keys(robot)'. You can directly assign it like this: 'let tempKeysRobot = Object.keys(robot);'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to initialize tempKyesRobot with an empty object on line 11 since you are assigning it a new value here. You can declare and assign it in one line.

tempValueRobot = Object.values(robot);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, you can directly assign 'tempValueRobot' with 'Object.values(robot)'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to initialize 'tempKyesRobot' and 'tempValueRobot' with empty objects on lines 11 and 12 if you are going to assign them arrays on lines 14 and 15. You can declare and assign them in one step.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, there is no need to initialize tempValueRobot with an empty object on line 12 since you are assigning it a new value here. You can declare and assign it in one line.


for (let i = 0; i < tempValueRobot.length; i++) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can be simplified. Use hasOwnProperty method

if (tempValueRobot.indexOf(tempValueRobot[i]) !== i) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'indexOf' method has a time complexity of O(n), which makes your code less efficient. Consider using a 'Set' to check for duplicate values, as it has a time complexity of O(1).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using indexOf inside a loop to check for duplicate values is inefficient as it results in an O(n^2) complexity. Consider using an object to track occurrences of values for a more efficient solution.

return null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for repeated values can be optimized. Instead of using 'indexOf', which has O(n) complexity for each check, consider using an object to track occurrences of values. This will allow you to check for duplicates in O(1) time.

}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InversedRobot, use inversedRobot instead of robot.


for (const key in robot) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more descriptive variable name instead of 'key'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the input object robot is not a good practice as it can lead to unexpected side effects. Instead, create a new object to store the inverted key-value pairs.

delete robot[key];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting properties from the original 'robot' object is not a good practice. It's better to create a new object and return it. This way, the original object remains unchanged.

}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid using nested for loops

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the input object 'robot' is not a good practice as it can lead to side effects. Instead, create a new object and return it without altering the original 'robot' object.


for (const i in tempKyesRobot) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid using nested for loops

robot[tempValueRobot[i]] = tempKyesRobot[i];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line of code is not clear. It's better to use meaningful variable names instead of 'i'. Also, consider using a single loop to check for duplicates and create the new object at the same time.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable 'i' in the for...in loop is misleading because it suggests an index, but it's actually a key. Use a more descriptive variable name, such as 'keyIndex' or 'key'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loop is unnecessary. You can invert the key-value pairs in the same loop where you check for duplicates to make the function more efficient.

}

return robot;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning the modified input object 'robot' does not align with the task description, which asks for a new object to be returned. Create and return a new object instead.

}

module.exports = inverseRobot;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to include a newline at the end of the file. Some tools and systems expect or require it for proper processing.

Loading