-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #770
base: main
Are you sure you want to change the base?
Solution #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the splitInteger
function and ensuring it meets the task requirements! 🎉 The code is correct, and all necessary files are present. While there are minor issues with the test case descriptions, they do not impact the functionality of your solution. Keep up the good work, and consider updating the test descriptions for clarity in the future. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -4,18 +4,20 @@ const splitInteger = require('./splitInteger'); | |||
|
|||
test(`should split a number into equal parts | |||
if a value is divisible by a numberOfParts`, () => { | |||
|
|||
expect(splitInteger(8, 1)).toEqual([8]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for this test case seems incorrect. It mentions splitting a number into equal parts if divisible, but the test is actually checking if splitting 8 into 1 part returns [8]. Consider revising the description to accurately reflect the test case.
}); | ||
|
||
test(`should return a part equals to a value | ||
when splitting into 1 part`, () => { | ||
|
||
expect(splitInteger(6, 2)).toEqual([3, 3]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for this test case does not match the expectation. The description suggests splitting into 1 part, but the test is actually splitting 6 into 2 parts. Update the description to accurately reflect the test case.
No description provided.