Develop #788
Develop #788
Conversation
added test for splitInteger function
There was a problem hiding this comment.
Great job on implementing the splitInteger function! 🎉 Your solution meets the task requirements and constraints effectively. While there are a couple of minor issues with the test cases, such as the incorrect test for splitInteger(17, 0) and the need to update the expectation for splitInteger(17, 4), these do not significantly impact the functionality of your code. Keep up the good work, and consider refining the test cases for even more robust testing. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| expect(splitInteger(17, 4)) | ||
| .toHaveLength(4); |
There was a problem hiding this comment.
The test case for splitInteger(17, 4) should expect the result [4, 4, 4, 5] according to the task description, not just the length of 4. Consider updating the expectation to check for the correct array content.
| expect(splitInteger(17, 0)) | ||
| .toEqual([]); |
There was a problem hiding this comment.
The test case for splitInteger(17, 0) is incorrect. According to the task description, the function should return an array with exactly numberOfParts elements. Since numberOfParts is 0, this test case is invalid as per the task requirements.
No description provided.