-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #2737
Open
joanna-konopacka
wants to merge
7
commits into
mate-academy:master
Choose a base branch
from
joanna-konopacka:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
solution #2737
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c3404b7
solution
joanna-konopacka 9134591
solution
joanna-konopacka 8ad514f
solution
joanna-konopacka d76f5a8
solution
joanna-konopacka 3aa537e
solution
joanna-konopacka 5249124
solution
joanna-konopacka 6d026f9
solution
joanna-konopacka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,36 @@ | ||
'use strict'; | ||
"use strict"; | ||
|
||
/** | ||
* @param {Object} state | ||
* @param {Object[]} actions | ||
*/ | ||
function transformState(state, actions) { | ||
// write code here | ||
for (const action of actions) { | ||
const { type } = action; | ||
|
||
switch (type) { | ||
case "addProperties": | ||
const { extraData } = action; | ||
if (extraData) { | ||
Object.assign(state, extraData); | ||
} | ||
break; | ||
|
||
case "removeProperties": | ||
const { keysToRemove } = action; | ||
if (keysToRemove) { | ||
for (const key of keysToRemove) { | ||
delete state[key]; | ||
} | ||
} | ||
break; | ||
|
||
case "clear": | ||
Object.keys(state).forEach((key) => { | ||
delete state[key]; | ||
}); | ||
break; | ||
|
||
default: | ||
break; | ||
} | ||
} | ||
} | ||
|
||
module.exports = transformState; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, there is a small issue with the "clear" case. When you want to clear all properties from the state object, using a for...in loop may not work as expected. Instead, you should use Object.keys to get an array of keys and then delete each key.