Develop #2319
Develop #2319
Conversation
src/makeRobotAccountant.js
Outdated
| if (counter > 2 && counter % 2 === 1) { | ||
| counter++; | ||
|
|
||
| return `Bzzz... Error!`; |
There was a problem hiding this comment.
would wrap it in a variable, e.g. error, then return error
There was a problem hiding this comment.
Actually, since we are not doing operations on this variable, it does not change or appear in different places, it's not a part of a list of options (like in stateful clones) we don't need to wrap it in a variable.
src/makeRobotAccountant.js
Outdated
| } else { | ||
| counter++; | ||
|
|
||
| return a + b; |
There was a problem hiding this comment.
here I would also wrap in a variable sum and return the sum
src/makeRobotAccountant.js
Outdated
| function getSum(a) { | ||
| function bullshitNesting(b) { | ||
| if (counter > 2 && counter % 2 === 1) { | ||
| counter++; | ||
|
|
||
| return `Bzzz... Error!`; | ||
| } else { | ||
| counter++; | ||
|
|
||
| return a + b; | ||
| } | ||
| } | ||
|
|
||
| return bullshitNesting; | ||
| } |
There was a problem hiding this comment.
You can just use arrow functions () => {} instead off naming your functions bullshitNesting. Please remember to avoid such Easter eggs.
src/makeRobotAccountant.js
Outdated
| if (counter > 2 && counter % 2 === 1) { | ||
| counter++; | ||
|
|
||
| return `Bzzz... Error!`; |
There was a problem hiding this comment.
Actually, since we are not doing operations on this variable, it does not change or appear in different places, it's not a part of a list of options (like in stateful clones) we don't need to wrap it in a variable.
src/makeRobotAccountant.js
Outdated
| } else { | ||
| counter++; | ||
|
|
||
| return a + b; |
src/makeRobotAccountant.js
Outdated
| function getSum(a) { | ||
| function bullshitNesting(b) { | ||
| if (counter > 2 && counter % 2 === 1) { | ||
| counter++; |
There was a problem hiding this comment.
move counter++ outside of if statements
src/makeRobotAccountant.js
Outdated
| counter++; | ||
|
|
||
| return `Bzzz... Error!`; | ||
| } else { |
There was a problem hiding this comment.
if you are using if with return there is no need for else keyword
if {
//code
return
}
return // some other code
No description provided.