Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1414

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SofiiaPelenska
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code correctly iterates over the people array and dynamically creates table rows with all the necessary details. Just a small note: the loop currently starts at index 1, which skips the first person in the array. If this wasn't intentional, you might want to adjust it to start from index 0 to include everyone. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

// write your code here
const table = document.querySelector('.dashboard');

for (let i = 1; i < people.length; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loop starts at index 1, which means it skips the first person in the 'people' array. If this is not intentional, consider starting the loop from index 0 to include all people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants