taskGenerateTable #1415
taskGenerateTable #1415
Conversation
There was a problem hiding this comment.
Great job on meeting the task requirements! 🎉 Your code successfully processes the people array and populates the table as expected. However, for future improvements, consider ensuring consistency in property names by using 'sex' instead of 'gender' throughout your code. Also, avoid redefining the people array inside the event listener to keep your code clean and efficient. Keep up the good work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| const people = [ | ||
| { | ||
| "name": "Bernardus de Causmaecker", | ||
| "gender": "m", | ||
| "born": 1721, | ||
| "died": 1789 | ||
| }, | ||
| { | ||
| "name": "Lieven de Causmaecker", | ||
| "gender": "m", | ||
| "born": 1696, | ||
| "died": 1724 | ||
| } | ||
| ]; |
There was a problem hiding this comment.
The 'people' array is redefined inside the DOMContentLoaded event listener. This is redundant since the 'people' array is already defined globally. Consider using the global 'people' array instead.
| const people = [ | ||
| { | ||
| "name": "Bernardus de Causmaecker", | ||
| "gender": "m", |
There was a problem hiding this comment.
The property 'gender' is used here, but in the global 'people' array, the property is named 'sex'. Ensure consistency in property names to avoid confusion.
| }, | ||
| { | ||
| "name": "Lieven de Causmaecker", | ||
| "gender": "m", |
There was a problem hiding this comment.
Again, 'gender' is used instead of 'sex'. Ensure consistency in property names throughout the code.
No description provided.