Solution #1422
Open
Solution #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Great job on meeting the task requirements! 🎉 The code processes the people array correctly and dynamically creates a table to display the details. Just a small note: there's a minor typo in the gender display logic where 'Famele' should be corrected to 'Female'. Keep up the great work and attention to detail! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/scripts/main.js
Outdated
Comment on lines
379
to
380
| } else { | ||
| genderCell.textContent = 'Famele'; |
There was a problem hiding this comment.
There is a typo in the word 'Famele'. It should be corrected to 'Female'. This is a minor issue but important for correct gender representation.
volodymyr-soltys97
suggested changes
Mar 5, 2025
src/scripts/main.js
Outdated
Comment on lines
379
to
380
| } else { | ||
| genderCell.textContent = 'Famele'; |
src/scripts/main.js
Outdated
Comment on lines
377
to
381
| if (human.sex === 'm') { | ||
| genderCell.textContent = 'Male'; | ||
| } else { | ||
| genderCell.textContent = 'Famele'; | ||
| } |
There was a problem hiding this comment.
Use ternary operator
Suggested change
| if (human.sex === 'm') { | |
| genderCell.textContent = 'Male'; | |
| } else { | |
| genderCell.textContent = 'Famele'; | |
| } | |
| genderCell.textContent = human.sex === 'm' ? 'Male' : 'Female'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK