make task #1311
make task #1311
Conversation
| this.radius = radius; | ||
| setColor(color); | ||
| getArea(); |
There was a problem hiding this comment.
| this.radius = radius; | |
| setColor(color); | |
| getArea(); | |
| super(color); | |
| this.radius = radius; |
|
|
||
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| Random rand = new Random(); |
refactor variable to final
| System.out.println("Circle{" + "radius=" + radius | ||
| + ", color='" + getColor() + '\'' + ", area=" + getArea() + '}'); | ||
| return ""; |
There was a problem hiding this comment.
| System.out.println("Circle{" + "radius=" + radius | |
| + ", color='" + getColor() + '\'' + ", area=" + getArea() + '}'); | |
| return ""; | |
| return "Circle{" + "radius=" + radius | |
| + ", color='" + getColor() + '\'' + ", area=" + getArea() + '}'; |
There was a problem hiding this comment.
behaviour - we can obtain the area of any figure and are able to draw it. To 'draw' means to print out all information about a figure using System.out.println() (you shouldn't override toString() method for this).
|
|
||
| public class ColorSupplier { | ||
| private final Random rand = new Random(); | ||
| private final String[] colors = new String[]{"white", "black", "blue", "red"}; |
|
|
||
| public Figure getRandomFigure() { | ||
| String randomFigure = listFigure[random.nextInt(listFigure.length)]; | ||
| int randomRange = 100; |
There was a problem hiding this comment.
should be class level constant.
randomRange is misleading name
| System.out.println("IsoscelesTrapezoid{" + "upSide=" + upSide | ||
| + ", downSide=" + downSide | ||
| + ", height=" + height + ", color='" | ||
| + getColor() + '\'' + ", area=" + getArea() + '}'); |
There was a problem hiding this comment.
behaviour - we can obtain the area of any figure and are able to draw it. To 'draw' means to print out all information about a figure using System.out.println() (you shouldn't override toString() method for this).
| figures[2] = new Circle("white", 10); | ||
| figures[3] = new Square("black", 5); | ||
| for (Figure figure : figures) { | ||
| figure.toString(); |
There was a problem hiding this comment.
consider adding interface instead of overriding toString
| white, | ||
| black, |
| return color; | ||
| } | ||
|
|
||
| public abstract void draw(); |
| import java.util.Random; | ||
|
|
||
| public class FigureSupplier { | ||
| private final int maxNumber = 100; |
| Circle, | ||
| Square, | ||
| Rectangle, | ||
| RightTriangle, | ||
| IsoscelesTrapezoid |
| public class Circle extends Figure { | ||
| private final int radius; | ||
|
|
||
| public Circle(Color color,int radius) { |
There was a problem hiding this comment.
There should be a space after the comma in the parameters list of the constructor.
| package core.basesyntax; | ||
|
|
||
| public class Square extends Figure { | ||
| private final double side; |
There was a problem hiding this comment.
this fields is marked as 'final' which means that it can't be changed after it's initialized. This is okay if you will never need to change this value, but if you want your objects to be mutable, you should remove the 'final' keyword.
There was a problem hiding this comment.
This object is designed to be immutable, which does not change after it is created. In fact, I should have made the shape classes themselves final (Circle, Square and others).
| import java.util.Random; | ||
|
|
||
| public class FigureSupplier { | ||
| public static final int MAX_NUMBER = 100; |
There was a problem hiding this comment.
The MAX_NUMBER constant could be private as it's not used outside of this class.
|
|
||
| public class FigureSupplier { | ||
| public static final int MAX_NUMBER = 100; | ||
| private final ColorSupplier colorSupplier = new ColorSupplier(); |
There was a problem hiding this comment.
The colorSupplier object could be static because its method is stateless, and it would be more efficient to have only one instance of ColorSupplier for all FigureSupplier objects.
| } | ||
|
|
||
| public Figure getDefaultFigure() { | ||
| return new Circle(Color.WHITE,10); |
| public Figure getDefaultFigure() { | ||
| return new Circle(Color.WHITE,10); | ||
| } | ||
|
|
| package core.basesyntax; | ||
|
|
||
| public class RightTriangle extends Figure { | ||
| private final double firstLeg; |
There was a problem hiding this comment.
this fields is marked as 'final' which means that it can't be changed after it's initialized. This is okay if you will never need to change this value, but if you want your objects to be mutable, you should remove the 'final' keyword.
| package core.basesyntax; | ||
|
|
||
| public class IsoscelesTrapezoid extends Figure { | ||
| private final double upSide; |
There was a problem hiding this comment.
this fields is marked as 'final' which means that it can't be changed after it's initialized. This is okay if you will never need to change this value, but if you want your objects to be mutable, you should remove the 'final' keyword.
| package core.basesyntax; | ||
|
|
||
| public abstract class Figure implements AreaCalculator, FigureDrawer { | ||
| private final Color color; |
There was a problem hiding this comment.
this field is marked as 'final' which means that it can't be changed after it's initialized. This is okay if you will never need to change this value, but if you want your objects to be mutable, you should remove the 'final' keyword.
| package core.basesyntax; | ||
|
|
||
| public class Circle extends Figure { | ||
| private final int radius; |
There was a problem hiding this comment.
this field is marked as 'final' which means that it can't be changed after it's initialized. This is okay if you will never need to change this value, but if you want your objects to be mutable, you should remove the 'final' keyword.
No description provided.