created classes, interface and abstract class for them, class ColorSupplier with public String getRandomColor(), class FigureSupplier with public Figure getRandomFigure() and getDefaultFigure(), also created main with random and default figures #1314

ddryzhov · 2023-10-07T11:57:58Z

No description provided.

…pplier with public String getRandomColor(), class FigureSupplier with public Figure getRandomFigure() and getDefaultFigure(), also created main with random and default figures

Ivan95kos · 2023-10-07T15:17:13Z

src/main/java/core/basesyntax/ColorSupplier.java

+
+public class ColorSupplier {
+    private final Random random = new Random();
+    private final String[] colors = new String[]{"Blue", "Red", "Yellow", "Green", "Black"};


create Enum Color instead of String

Suggested change

private final String[] colors = new String[]{"Blue", "Red", "Yellow", "Green", "Black"};

Ivan95kos · 2023-10-07T15:19:35Z

src/main/java/core/basesyntax/Figure.java

@@ -0,0 +1,13 @@
+package core.basesyntax;
+
+public abstract class Figure implements FigureBehaviour {


You missed one behavior:

Suggested change

public abstract class Figure implements FigureBehaviour {

public abstract class Figure implements AreaCalculator, Drawable {

public interface AreaCalculator { double getArea(); }

Ivan95kos · 2023-10-07T15:19:58Z

src/main/java/core/basesyntax/FigureBehaviour.java

+public interface FigureBehaviour {
+    void printfInfoAboutFigure();


Suggested change

public interface FigureBehaviour {

void printfInfoAboutFigure();

public interface Drawable {

void draw();

Ivan95kos · 2023-10-07T15:20:27Z

src/main/java/core/basesyntax/FigureSupplier.java

+
+    public Figure getRandomFigure() {
+        String figureColor = colorSupplier.getRandomColor();
+        int randomFigure = random.nextInt(5);


use constants instead of numbers

Ivan95kos · 2023-10-07T15:20:39Z

src/main/java/core/basesyntax/FigureSupplier.java

+
+        switch (randomFigure) {
+            case 0:
+                return new Circle(figureColor, random.nextDouble() * 9.0 + 1.0);


All magic numbers, strings, and symbols in your code should be constants.
this article

Ivan95kos · 2023-10-07T15:20:51Z

src/main/java/core/basesyntax/FigureSupplier.java

+            case 4:
+                return new Square(figureColor, random.nextDouble() * 9.0 + 1.0);
+            default:
+                return null;


Suggested change

return null;

return getDefaultFigure();

Ivan95kos · 2023-10-07T15:20:59Z

src/main/java/core/basesyntax/FigureSupplier.java

+    }
+
+    public Figure getDefaultFigure() {
+        return new Circle("White", 10);


All magic numbers, strings, and symbols in your code should be constants.
this article

Ivan95kos · 2023-10-07T15:21:22Z

src/main/java/core/basesyntax/Main.java

+
+        Figure[] figures = new Figure[6];
+
+        for (int i = 0; i < 3; i++) {


use one loop for

…me of 2 interfaces, used constants instead of numbers and Strings, used one loop for in Main

Ivan95kos

left a few comments

Ivan95kos · 2023-10-07T16:22:39Z

src/main/java/core/basesyntax/Color.java

+package core.basesyntax;
+
+public enum Color {
+    Blue,


naming convention: https://mate-academy.github.io/style-guides/java/java.html#s4.8.1-enum-classes

Suggested change

Blue,

BLUE,

Ivan95kos · 2023-10-07T16:24:06Z

src/main/java/core/basesyntax/ColorSupplier.java

+    private final Color[] colors = new Color[]{Color.Blue, Color.Red,
+            Color.Yellow, Color.Green, Color.Black};


Suggested change

private final Color[] colors = new Color[]{Color.Blue, Color.Red,

Color.Yellow, Color.Green, Color.Black};

private final Color[] colors = Color.values();

Ivan95kos · 2023-10-07T16:24:59Z

src/main/java/core/basesyntax/FigureSupplier.java

+    static final double FIGURE_RADIUS = 9.0 + 1.0;
+    static final String DEFAULT_CIRCLE_COLOUR = "White";


use Enum

Suggested change

static final double FIGURE_RADIUS = 9.0 + 1.0;

static final String DEFAULT_CIRCLE_COLOUR = "White";

static final double FIGURE_RADIUS = 9.0 + 1.0;

static final String DEFAULT_COLOR = Color.WHITE.name();

Ivan95kos

Nice

created classes, interface and abstract class for them, class ColorSu…

a200077

…pplier with public String getRandomColor(), class FigureSupplier with public Figure getRandomFigure() and getDefaultFigure(), also created main with random and default figures

Ivan95kos suggested changes Oct 7, 2023

View reviewed changes

created Enum Color, added one behavior(new interface), changed the na…

eba5c7b

…me of 2 interfaces, used constants instead of numbers and Strings, used one loop for in Main

Ivan95kos suggested changes Oct 7, 2023

View reviewed changes

fixed

b58e1de

Ivan95kos approved these changes Oct 7, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

created classes, interface and abstract class for them, class ColorSupplier with public String getRandomColor(), class FigureSupplier with public Figure getRandomFigure() and getDefaultFigure(), also created main with random and default figures #1314

created classes, interface and abstract class for them, class ColorSupplier with public String getRandomColor(), class FigureSupplier with public Figure getRandomFigure() and getDefaultFigure(), also created main with random and default figures #1314

ddryzhov commented Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos left a comment

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos Oct 7, 2023

Ivan95kos left a comment

		@@ -0,0 +1,13 @@
		package core.basesyntax;

		public abstract class Figure implements FigureBehaviour {

		public interface FigureBehaviour {
		void printfInfoAboutFigure();


		Figure[] figures = new Figure[6];

		for (int i = 0; i < 3; i++) {

		private final Color[] colors = new Color[]{Color.Blue, Color.Red,
		Color.Yellow, Color.Green, Color.Black};

		static final double FIGURE_RADIUS = 9.0 + 1.0;
		static final String DEFAULT_CIRCLE_COLOUR = "White";

created classes, interface and abstract class for them, class ColorSupplier with public String getRandomColor(), class FigureSupplier with public Figure getRandomFigure() and getDefaultFigure(), also created main with random and default figures #1314

Are you sure you want to change the base?

created classes, interface and abstract class for them, class ColorSupplier with public String getRandomColor(), class FigureSupplier with public Figure getRandomFigure() and getDefaultFigure(), also created main with random and default figures #1314

Conversation

ddryzhov commented Oct 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ivan95kos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ivan95kos left a comment

Choose a reason for hiding this comment