created figures and interfaces with calculation and drawing methods #1326

Tarask2 · 2023-10-14T15:24:35Z

No description provided.

sokimaaa · 2023-10-14T16:14:52Z

src/main/java/core/basesyntax/ColorSupplier.java

+    private final String[] colors = {"red", "green", "blue", "yellow", "purple", "orange", "pink"};
+
+    public String getRandomColor() {
+        Random random = new Random();


consider making class-level field

sokimaaa · 2023-10-14T16:15:24Z

src/main/java/core/basesyntax/DrawFigure.java

@@ -0,0 +1,5 @@
+package core.basesyntax;
+
+interface DrawFigure {


No need to tight interface name for figure only

Suggested change

interface DrawFigure {

interface Drawable {

sokimaaa · 2023-10-14T16:17:40Z

src/main/java/core/basesyntax/FigureSupplier.java

+        Random random = new Random();
+        ColorSupplier colorSupplier = new ColorSupplier();
+
+        int figureType = random.nextInt(5);


avoid using magic numbers

consider making it constant

sokimaaa · 2023-10-14T16:18:15Z

src/main/java/core/basesyntax/FigureSupplier.java

+
+public class FigureSupplier {
+    public Figure getRandomFigure() {
+        Random random = new Random();


consider making class-level field

Tarask2 · 2023-10-22T23:41:59Z

Correct Task !!!
Pleas check !

kerrrusha · 2023-10-24T12:37:30Z

src/main/java/core/basesyntax/FigureSupplier.java

    public Figure getRandomFigure() {
-        Random random = new Random();
        ColorSupplier colorSupplier = new ColorSupplier();


can be class-level private final variable

kerrrusha · 2023-10-24T12:37:37Z

src/main/java/core/basesyntax/FigureSupplier.java

@@ -3,11 +3,12 @@
 import java.util.Random;

 public class FigureSupplier {
+    private Random random = new Random();


could be final

kerrrusha · 2023-10-24T12:39:20Z

src/main/java/core/basesyntax/FigureSupplier.java

@@ -29,7 +30,7 @@ public Figure getRandomFigure() {
                int topBase = random.nextInt() * 10;
                int bottomBase = random.nextInt() * 10;
                int heightTrapezoid = random.nextInt() * 10;
-                return new IsoscelesTrapezoid(color,topBase, bottomBase, heightTrapezoid);
+                return new IsoscelesTrapezoid(color, topBase, bottomBase, heightTrapezoid);

            default:
                return null;


you can return default figure instead of null

kerrrusha · 2023-10-24T12:40:27Z

src/main/java/core/basesyntax/ColorSupplier.java

@@ -3,10 +3,10 @@
 import java.util.Random;

 public class ColorSupplier {
+    private Random random = new Random();
    private final String[] colors = {"red", "green", "blue", "yellow", "purple", "orange", "pink"};


could be private static final

kerrrusha · 2023-10-24T12:40:33Z

src/main/java/core/basesyntax/ColorSupplier.java

@@ -3,10 +3,10 @@
 import java.util.Random;

 public class ColorSupplier {
+    private Random random = new Random();


could be private final

Rommelua

Before you create PR with your homework, you need to go through the checklist under the task and correct all the points described there. The mentor will not check the work until the checklist points are corrected

Rommelua · 2023-10-30T11:21:34Z

src/main/java/core/basesyntax/AreaCalculator.java

+interface AreaCalculator {
+
+    double calculateArea();


Rommelua · 2023-10-30T11:21:51Z

src/main/java/core/basesyntax/ColorSupplier.java

+class ColorSupplier {
+


Rommelua · 2023-10-30T11:23:43Z

src/main/java/core/basesyntax/ColorSupplier.java

+    private static final String[] colors = {"red", "green", "blue", "yellow", "purple",
+            "orange", "pink"};


Let's remove this array and create enum Color (as a separate class)

Rommelua · 2023-10-30T11:24:36Z

src/main/java/core/basesyntax/FigureSupplier.java

+
+    public Figure getRandomFigure() {
+
+        final int figureType = random.nextInt(5);


Sanderfuck · 2023-11-07T09:47:49Z

src/main/java/core/basesyntax/Colors.java

+package core.basesyntax;
+
+enum Colors {
+    RED, GREEN, WHITE, BLACK, BLUE;


Better write in stack instead line

Sanderfuck · 2023-11-07T09:48:49Z

src/main/java/core/basesyntax/FigureSupplier.java

+            case 0:
+                return new Square(color, sideOrRadius);
+            case 1:
+                return new Circle(color, sideOrRadius);
+            case 2:
+                double width = random.nextDouble() * 10;
+                double height = random.nextDouble() * 10;
+                return new Rectangle(color, (int) width, (int) height);
+            case 3:
+                double firstLeg = random.nextDouble() * 10;
+                double secondLeg = random.nextDouble() * 10;
+                return new RightTriangle(color, (int) secondLeg, (int) firstLeg);
+            case 4:
+                int topBase = random.nextInt() * 10;
+                int bottomBase = random.nextInt() * 10;
+                int heightTrapezoid = random.nextInt() * 10;
+                return new IsoscelesTrapezoid(color, topBase, bottomBase, heightTrapezoid);


For every case you can create own method and you have a lot of duplicate code with your random values

Sanderfuck · 2023-11-07T09:50:30Z

src/main/java/core/basesyntax/FigureSupplier.java

+    }
+
+    public Figure getDefaultFigure() {
+        return new Circle("white", 10);


Use constant for parameters

created shapes and interfaces with calculation and drawing methods

fcb5c3a

sokimaaa suggested changes Oct 14, 2023

View reviewed changes

correct all mistake!!!

c7d1f56

kerrrusha suggested changes Oct 24, 2023

View reviewed changes

fixed all mistake!!!add final to veriable

9e34819

Tarask2 requested review from kerrrusha and sokimaaa October 30, 2023 04:57

Rommelua suggested changes Oct 30, 2023

View reviewed changes

check my all my mistake

b1130f8

Tarask2 requested a review from Rommelua November 6, 2023 20:51

Sanderfuck suggested changes Nov 7, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

created figures and interfaces with calculation and drawing methods #1326

created figures and interfaces with calculation and drawing methods #1326

Tarask2 commented Oct 14, 2023

sokimaaa Oct 14, 2023

sokimaaa Oct 14, 2023

sokimaaa Oct 14, 2023

sokimaaa Oct 14, 2023

Tarask2 commented Oct 22, 2023

kerrrusha Oct 24, 2023

kerrrusha Oct 24, 2023

kerrrusha Oct 24, 2023

kerrrusha Oct 24, 2023

kerrrusha Oct 24, 2023

Rommelua left a comment

Rommelua Oct 30, 2023

Rommelua Oct 30, 2023

Rommelua Oct 30, 2023

Rommelua Oct 30, 2023

Sanderfuck Nov 7, 2023

Sanderfuck Nov 7, 2023

Sanderfuck Nov 7, 2023

		@@ -0,0 +1,5 @@
		package core.basesyntax;

		interface DrawFigure {

		private static final String[] colors = {"red", "green", "blue", "yellow", "purple",
		"orange", "pink"};


		public Figure getRandomFigure() {

		final int figureType = random.nextInt(5);

created figures and interfaces with calculation and drawing methods #1326

Are you sure you want to change the base?

created figures and interfaces with calculation and drawing methods #1326

Conversation

Tarask2 commented Oct 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tarask2 commented Oct 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rommelua left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment