Created an example of a figure factory #1330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rommelua
suggested changes
Oct 19, 2023
| package core.basesyntax; | ||
|
|
||
| public class Circle extends Figure { | ||
| private double radius = 0; |
There was a problem hiding this comment.
Suggested change
| private double radius = 0; | |
| private double radius; |
Comment on lines
6
to
8
| Circle() { | ||
| super("circle", Color.WHITE); | ||
| } |
| super("circle", Color.WHITE); | ||
| } | ||
|
|
||
| Circle(Color color) { |
Comment on lines
19
to
23
| if (radius > 0) { | ||
| this.radius = radius; | ||
| } else { | ||
| System.out.println("Circle radius can't be negative or equal to zero!"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (radius > 0) { | |
| this.radius = radius; | |
| } else { | |
| System.out.println("Circle radius can't be negative or equal to zero!"); | |
| } | |
| this.radius = radius; |
| @@ -0,0 +1,5 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public interface DrawAble { | |||
There was a problem hiding this comment.
Suggested change
| public interface DrawAble { | |
| public interface Drawable { |
| package core.basesyntax; | ||
|
|
||
| public interface AreaCalculator { | ||
| double area(); |
There was a problem hiding this comment.
Suggested change
| double area(); | |
| double getArea(); |
| public class FigureSupplier { | ||
| private final Random random = new Random(); | ||
| private final ColorSupplier colorSupplier = new ColorSupplier(); | ||
| private final int figureAmount = 5; |
|
|
||
| public Figure getDefaultFigure() { | ||
| Circle circle = new Circle(); | ||
| circle.setRadius(10); |
kerrrusha
suggested changes
Oct 20, 2023
| public class Circle extends Figure { | ||
| private double radius; | ||
|
|
||
| public Circle() { |
There was a problem hiding this comment.
KISS - if you dont need default constructor - just delete it
Comment on lines
41
to
43
| Circle circle = new Circle(); | ||
| circle.setRadius(DEFAULT_RADIUS); | ||
| return circle; |
There was a problem hiding this comment.
Suggested change
| Circle circle = new Circle(); | |
| circle.setRadius(DEFAULT_RADIUS); | |
| return circle; | |
| return new Circle(DEFAULT_RADIUS); |
|
|
||
| public class FiguresExpo { | ||
| public static void main(String[] args) { | ||
| Figure[] figures = new Figure[10]; |
| FigureSupplier figureSupplier = new FigureSupplier(); | ||
|
|
||
| for (int i = 0; i < figures.length; i++) { | ||
| if (i < 5) { |
There was a problem hiding this comment.
what if we would have only 2 figures? think about how to make this code more universal
| } | ||
| } | ||
|
|
||
| for (Figure figure: figures) { |
There was a problem hiding this comment.
no need to create another loop, can do this in the loop above
…plier class/ create constructor in FigureSupplier for set figures array size
sokimaaa
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.