Home Work solution jv-oop-advanced #1740

Danila2006 · 2024-11-11T17:03:21Z

Added interface CalculateArea.java, class Circle.java, class ColorSupplier.java, interface Colors.java, interface Drawable.java, class Figure.java, class FigureSupplier.java, interface Figures.java, class IsoscelesTrapezoid.java, class Rectangle.java, class RightTriangle.java, class Square.java; Changed HelloWorld.java

…plier.java, interface Colors.java, interface Drawable.java, class Figure.java, class FigureSupplier.java, interface Figures.java, class IsoscelesTrapezoid.java, class Rectangle.java, class RightTriangle.java, class Square.java; Changed HelloWorld.java

mateacademy-ai-mentor

Thank you for your hard work on this pull request! While your implementation is mostly solid, there are a few critical issues that need to be addressed before we can approve it:

Non-English Text in drawFigure() Methods: Several classes (Circle, RightTriangle, Square, IsoscelesTrapezoid, Rectangle) contain non-English text in their drawFigure() methods. It's important to use English for all messages to ensure consistency and universality across the codebase.
Returning null in FigureSupplier: The getRandomFigure() method in the FigureSupplier class returns null in the default case. This is not recommended as it can lead to NullPointerExceptions. Consider handling this case by throwing an exception or returning a default figure.
Use of toString() for Enum Constants: In the ColorSupplier class, replace toString() with name() for getting the string representation of enum constants. This aligns with best practices and ensures reliability.
Hardcoded Pi Value: The Circle class uses a hardcoded value of 3.14 for Pi. Replace this with Math.PI for better precision in calculations.

These changes are necessary to ensure the code meets the core requirements and maintains high quality. Once these issues are resolved, your pull request will be ready for approval. Keep up the great work, and don't hesitate to reach out if you have any questions! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2024-11-11T17:06:20Z

src/main/java/core/basesyntax/Circle.java

+    }
+
+    public double getS() {
+        return 3.14 * Math.pow(this.radius, 2);


Consider using Math.PI instead of 3.14 for better precision in calculating the area of the circle.

mateacademy-ai-mentor · 2024-11-11T17:06:20Z

src/main/java/core/basesyntax/Circle.java

+        System.out.println("Коло { радіус = " + this.radius + ", площа = "
+                            + getS() + ", колір - " + getColor() + " }");


The drawFigure() method contains non-English text. According to the checklist, you should use English for messages to ensure the code is universal and consistent.

mateacademy-ai-mentor · 2024-11-11T17:06:20Z

src/main/java/core/basesyntax/ColorSupplier.java

+    public String getRandomColor() {
+        int index = new Random().nextInt(Colors.values().length);
+        Colors color = Colors.values()[index];
+        return color.toString();


Instead of using toString(), use name() to get the string representation of the enum constant. This is a more reliable method as per the checklist guidelines.

mateacademy-ai-mentor · 2024-11-11T17:06:20Z

src/main/java/core/basesyntax/FigureSupplier.java

+        int index = random.nextInt(Figures.values().length);
+        Figures figure = Figures.values()[index];
+
+        switch (figure.toString()) {


Instead of using toString(), use name() to get the string representation of the enum constant. This is a more reliable method as per the checklist guidelines.

mateacademy-ai-mentor · 2024-11-11T17:06:20Z

src/main/java/core/basesyntax/FigureSupplier.java

+                        random.nextDouble() * 100,
+                        random.nextDouble() * 100);
+            default:
+                return null;


Returning null from a method is considered a bad practice. Consider handling the default case differently, such as by throwing an exception or returning a default figure.

mateacademy-ai-mentor · 2024-11-11T17:06:21Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+        System.out.println("Рівнобічна трапеція { основа1 = " + this.base1
+                            + ", основа2 = " + this.base2
+                            + ", висота = " + this.height + ", площа = " + getS()
+                            + "колір - " + getColor() + " }");


The drawFigure() method contains non-English text. According to the checklist, you should use English for messages to ensure the code is universal and consistent.

mateacademy-ai-mentor · 2024-11-11T17:06:21Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+                            + ", висота = " + this.height + ", площа = " + getS()
+                            + "колір - " + getColor() + " }");


There is a missing space before 'колір'. Ensure proper spacing for readability.

mateacademy-ai-mentor · 2024-11-11T17:06:21Z

src/main/java/core/basesyntax/Rectangle.java

+        System.out.println("Прямокутник { сторона1 = " + this.side1 + ", сторона2 = " + this.side2
+                            + ", площа = " + getS() + ", колір - " + getColor() + " }");


The drawFigure() method contains non-English text. According to the checklist, you should use English for messages to ensure the code is universal and consistent.

mateacademy-ai-mentor · 2024-11-11T17:06:21Z

src/main/java/core/basesyntax/RightTriangle.java

+        System.out.println("Прямокутний трикутник { катет1 = " + this.leg1 + ", катет2 = "
+                            + this.leg2 + ", гіпотенуза = " + this.hypotenusa
+                            + ", площа = " + getS()
+                            + ", колір - " + getColor() + " }");


The drawFigure() method contains non-English text. According to the checklist, you should use English for messages to ensure the code is universal and consistent.

mateacademy-ai-mentor · 2024-11-11T17:06:21Z

src/main/java/core/basesyntax/Square.java

+        System.out.println("Квадрат { сторона = " + this.side + ", площа = "
+                            + getS() + ", колір - " + getColor() + " }");


The drawFigure() method contains non-English text. According to the checklist, you should use English for messages to ensure the code is universal and consistent.

mateacademy-ai-mentor

Review Summary

Great job on addressing the previous issues and aligning your code with the task requirements! 🎉 Your implementation now meets the necessary standards, and the improvements you've made are commendable. Here are some key points and suggestions for further enhancement:

Non-English Text in drawFigure() Methods: You've successfully updated the drawFigure() methods in all relevant classes to use English text, ensuring consistency and universality across the codebase.
Returning null in FigureSupplier: The getRandomFigure() method no longer returns null. Instead, it throws an IllegalStateException in the default case, which is a better practice.
Use of toString() for Enum Constants: The ColorSupplier class now uses name() instead of toString() for getting the string representation of enum constants, aligning with best practices.
Hardcoded Pi Value: The Circle class now uses Math.PI instead of a hardcoded value for Pi, ensuring better precision in calculations.
Loop Condition: Consider using i < 3 instead of i <= 2 for the loop condition in HelloWorld.java to follow the conventional pattern and avoid confusion.
Consistency in Enum Usage: Ensure consistency by using Colors.WHITE.name() instead of Colors.WHITE.toString().

Although there are minor issues, the decision to approve is made to help you move forward with your learning. Please review the comments to further improve your code. Remember, addressing these points will enhance your coding skills and prevent similar issues in the future. Keep up the great work and continue learning from your experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-11-12T09:38:25Z

src/main/java/core/basesyntax/FigureSupplier.java

+    }
+
+    public Figure getDefaultFigure() {
+        return new Circle(Colors.WHITE.toString(), 10);


Consider using Colors.WHITE.name() instead of Colors.WHITE.toString() for consistency with the rest of the codebase.

mateacademy-ai-mentor · 2024-11-12T09:38:25Z

src/main/java/core/basesyntax/HelloWorld.java


+        for (int i = 0; i <= 2; i++) {


The loop condition i <= 2 should be i < 3 to avoid confusion and ensure consistency with the typical loop pattern. Both conditions are functionally equivalent here, but using i < 3 is more conventional.

mateacademy-ai-mentor suggested changes Nov 11, 2024

View reviewed changes

Files modified after AI check

ef6d8b7

Danila2006 requested a review from mateacademy-ai-mentor November 12, 2024 09:36

mateacademy-ai-mentor approved these changes Nov 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Home Work solution jv-oop-advanced #1740

Home Work solution jv-oop-advanced #1740

Danila2006 commented Nov 11, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor Nov 11, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Nov 12, 2024

mateacademy-ai-mentor Nov 12, 2024

		System.out.println("Коло { радіус = " + this.radius + ", площа = "
		+ getS() + ", колір - " + getColor() + " }");

		+ ", висота = " + this.height + ", площа = " + getS()
		+ "колір - " + getColor() + " }");

		System.out.println("Прямокутник { сторона1 = " + this.side1 + ", сторона2 = " + this.side2
		+ ", площа = " + getS() + ", колір - " + getColor() + " }");

		System.out.println("Квадрат { сторона = " + this.side + ", площа = "
		+ getS() + ", колір - " + getColor() + " }");

Home Work solution jv-oop-advanced #1740

Are you sure you want to change the base?

Home Work solution jv-oop-advanced #1740

Conversation

Danila2006 commented Nov 11, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment