Realized the creation of a generator of geometric shapes with random … #1753
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code is generally well-structured and meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:
-
Constructor Error in
RectangleClass: There's a critical mistake in the constructor wherethis.widthis assigned twice, which affects the functionality of the area calculation. This needs to be corrected tothis.height = height;. -
Variable Naming in
RightTriangleClass: The typo in the variable namefistLegshould be corrected tofirstLegto ensure clarity and maintainability. -
Accessibility of
colorField: Ensure that thecolorfield in theFigureclass is accessible in theCircleclass. Ifcoloris private, consider adding a getter method inFigure.
These issues are important to resolve as they impact the functionality and clarity of your code. Once these are fixed, your code will be in great shape! Keep up the excellent work, and don't hesitate to reach out if you have any questions or need further assistance. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| System.out.println("Figure: circle, area: " + getArea() | ||
| + " radius: " + radius + " color " + color); |
There was a problem hiding this comment.
The color field is accessed directly, assuming it is a protected or public field in the Figure class. If color is private in Figure, you need to provide a getter method in Figure to access it.
There was a problem hiding this comment.
🔄 Исправьте проблемы, внесите изменения, а затем повторно запросите мою проверку с помощью Re-request reviewкнопки на вкладке «Рецензенты».
Где эта кнопка?
|
|
||
| public class ColorSupplier { | ||
| private static final Random random = new Random(); | ||
| private static final String[] Colors = {"red", "blue", "yellow", "green", "purple", "black"}; |
There was a problem hiding this comment.
The array Colors should follow the Java naming convention for constants, which is all uppercase letters with words separated by underscores. Consider renaming it to COLORS.
| import java.util.Random; | ||
|
|
||
| public class FigureSupplier { | ||
| private static final Random random2 = new Random(); |
There was a problem hiding this comment.
The variable random2 should follow a more descriptive naming convention. Consider renaming it to random or randomGenerator for clarity.
| public Rectangle(String color, double width, double height) { | ||
| super(color); | ||
| this.width = width; | ||
| this.width = height; |
There was a problem hiding this comment.
There is a mistake in the constructor: this.width = height; should be this.height = height;. This error causes the height field to be incorrectly initialized, affecting the area calculation.
| package core.basesyntax; | ||
|
|
||
| public class RightTriangle extends Figure { | ||
| private double fistLeg; |
There was a problem hiding this comment.
There is a typo in the variable name fistLeg. It should be firstLeg to accurately describe the first leg of the triangle.
Realized the creation of a generator of geometric shapes with random values