added requested methods #1164
Open
added requested methods #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Jan 12, 2025
| @@ -9,6 +9,10 @@ public User(String email, String password) { | |||
| this.password = password; | |||
| } | |||
|
|
|||
| public User(String email) { | |||
| @@ -15,6 +15,10 @@ public class UserService { | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
| return null; | |||
| if (email == "[email protected]" || email == "[email protected]") { | |||
There was a problem hiding this comment.
in for loop get from users array user.getEmail() and compare it with method argument email
| @@ -11,6 +11,11 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| if (email.equals("[email protected]") && password.equals("1234") || email.equals("[email protected]") | |||
There was a problem hiding this comment.
Create instanse of UserService
find user by email
return true if user by email exists and passed password is equal to user's password
Elena-Bruyako
suggested changes
Jan 12, 2025
| @@ -11,6 +13,12 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| UserService userService = new UserService(); | |||
There was a problem hiding this comment.
it should be class-level variable, don't need to create new UserService() each time when login method is called
Comment on lines
18
to
22
| if (foundUser != null && password.equals(foundUser.getPassword())) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (foundUser != null && password.equals(foundUser.getPassword())) { | |
| return true; | |
| } else { | |
| return false; | |
| } | |
| return foundUser != null && password.equals(foundUser.getPassword()); |
sarakhmen
suggested changes
Jan 12, 2025
| @@ -1,16 +1,20 @@ | |||
| package mate.academy.service; | |||
|
|
|||
| public class AuthenticationService { | |||
| private UserService userService = new UserService(); | |||
| // User foundUser = userService.findByEmail(email); | |||
There was a problem hiding this comment.
Suggested change
| // User foundUser = userService.findByEmail(email); |
remove redundant commented lines
| * @return true if user by email exists and passed password is equal to user's password. | ||
| * Return false in any other cases. | ||
| */ | ||
|
|
| @@ -3,6 +3,7 @@ | |||
| import mate.academy.model.User; | |||
|
|
|||
| public class UserService { | |||
|
|
|||
liliia-ponomarenko
approved these changes
Jan 13, 2025
Comment on lines
+16
to
+17
| return (userService.findByEmail(email) != null && password | ||
| .equals(userService.findByEmail(email).getPassword())) ? true : false; |
There was a problem hiding this comment.
better create separate variable for userService.findByEmail(email) and avoid redundant call of this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.