Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solution #130

wants to merge 3 commits into from

Conversation

Mariiaantoniv
Copy link

VitaliyBondarenko1982
VitaliyBondarenko1982 suggested changes Sep 22, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Needs some improvements.

  • suggest to keep dropdown options hidden by default
    Screenshot 2024-09-22 at 17 42 28
    Screenshot 2024-09-22 at 17 45 17
  • typo in form onsubmit handler. it is a reason leads to 405 page after click on submit button
    Screenshot 2024-09-22 at 17 44 13
  • add cursor pointer for submit form button. check other interactive elements.

SanyaBratashchuk
SanyaBratashchuk approved these changes Sep 23, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. add transitions for hover effects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 Awaiting requested review from VitaliyBondarenko1982

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariiaantoniv @VitaliyBondarenko1982 @SanyaBratashchuk