Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #137

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

solution #137

wants to merge 14 commits into from

Conversation

diana-tuz
Copy link

@diana-tuz diana-tuz commented Nov 18, 2024

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Fix text wrap in this button
image
  1. The user cannot be able to change size of the textarea field
image
  1. After submit the form don't need refresh page and scroll to top, yon need only reset form fields
image
  1. Fix height for the menu and remove scroll when menu is open
image
  1. Fix this block on the tablet version, check it on the design
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to fix all comments from the previous review, also, change the autofill styles for the form fields
https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image

@diana-tuz
Copy link
Author

diana-tuz commented Nov 20, 2024

@volodymyr-soltys97 Hi!
In the last commit, I added styles for autocomplete and some fixes for form submission.
But I'd fixed all the other of your previous comments in previous, could you provide me a little bit more detail on what else you want to be fixed?

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants