Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog_hover #2021

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readme.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Frontend practice with catalog page and hovers
Replace `<your_account>` with your Github username and copy the links to Pull Request description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog_hovers/)
- [DEMO LINK](https://usernameluke.github.io/layout_catalog_hovers/)

> Follow [this instructions](https://github.com/mate-academy/layout_task-guideline#how-to-solve-the-layout-tasks-on-github)

Expand Down
2 changes: 1 addition & 1 deletion src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
>
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet">

<link rel="stylesheet" href="styles/main.scss">
<link rel="stylesheet" href="styles/main.css">
</head>
<body class="page__body">
<header class="header">
Expand Down
7 changes: 7 additions & 0 deletions src/styles/blocks/catalog.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@
border-radius: 5px;
margin-bottom: 48px;

transition-duration: 300ms;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to set transitioned properties explictly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed


&:hover {
transform: scale(120%);
color: #34568b;
}

&:not(:nth-child(4n)) {
margin-right: 48px;
}
Expand Down
5 changes: 5 additions & 0 deletions src/styles/blocks/header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,10 @@
text-transform: uppercase;
font-size: 12px;
font-weight: 500;
transition-duration: 300ms;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix here as well

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed


&:hover {
color: #00acdc;
}
}
}
83 changes: 83 additions & 0 deletions src/styles/main.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/styles/main.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading