Skip to content

Commit

Permalink
fix bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
NataliiaNudyk committed Dec 17, 2024
1 parent a6c38ed commit 243ab97
Show file tree
Hide file tree
Showing 6 changed files with 35 additions and 30 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Adapt the page to the following screens:
11. `git push origin develop` - to send you code for PR.
12. Create a Pull Request (PR) from your branch `develop` to branch `master` of original repo.
13. Replace `<your_account>` with your Github username in the
[DEMO LINK](https://<your_account>.github.io/layout_dia/).
[DEMO LINK](https://NataliiaNudyk.github.io/layout_dia/).
14. Copy `DEMO LINK` to the PR description.

> To update you PR repeat steps 7-11.
17 changes: 10 additions & 7 deletions src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -213,31 +213,31 @@ <h4 class="slider__title">Intro</h4>
<li class="nav__item">
<a
href="#about-us"
class="nav__link menu__link"
class="nav__link"
>
About us
</a>
</li>
<li class="nav__item">
<a
href="#services"
class="nav__link menu__link"
class="nav__link"
>
Services
</a>
</li>
<li class="nav__item">
<a
href="#testimonials"
class="nav__link menu__link"
class="nav__link"
>
Testimonials
</a>
</li>
<li class="nav__item">
<a
href="#contact-us"
class="nav__link menu__link"
class="nav__link"
>
Contact Us
</a>
Expand Down Expand Up @@ -603,15 +603,18 @@ <h3 class="footer__title">Contact us</h3>
<div class="contact-us__label">our socials</div>
<div class="contact-us__icons">
<a
href="#"
href="https://www.facebook.com/?locale=uk_UA"
target="_blank"
class="contact-us__icon-link contact-us__icon-facebook"
></a>
<a
href="#"
href="https://x.com/?lang=uk"
target="_blank"
class="contact-us__icon-link contact-us__icon-twitter"
></a>
<a
href="#"
href="https://www.instagram.com/"
target="_blank"
class="contact-us__icon-link contact-us__icon-instagram"
></a>
</div>
Expand Down
1 change: 0 additions & 1 deletion src/styles/blocks/header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
&__top {
display: flex;
justify-content: space-between;
align-items: center;
padding-top: 20px;

@include on-small-desktop {
Expand Down
21 changes: 0 additions & 21 deletions src/styles/blocks/menu.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,4 @@
row-gap: 42px;
font-size: 22px;
}

&__link {
position: relative;

&::after {
content: '';
display: block;
position: absolute;
background-color: #fff;
height: 1px;
width: 100%;
bottom: -8px;

transition: transform 0.3s;
transform: scale(0);
}

&:hover::after {
transform: scale(1);
}
}
}
2 changes: 2 additions & 0 deletions src/styles/blocks/nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,7 @@
&__link {
color: $main-text-color;
text-decoration: none;

@include menu-hover;
}
}
22 changes: 22 additions & 0 deletions src/styles/utils/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,26 @@
border: none;
border-radius: 8px;
outline: none;
cursor: pointer;
}

@mixin menu-hover {
position: relative;

&::after {
content: '';
display: block;
position: absolute;
background-color: $btn-color;
height: 2px;
width: 100%;
bottom: -8px;

transition: transform 0.3s;
transform: scale(0);
}

&:hover::after {
transform: scale(1);
}
}

0 comments on commit 243ab97

Please sign in to comment.