Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task solution #1017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

MannyShussan
Copy link

@julianFBarbosa
Copy link

julianFBarbosa commented Dec 7, 2024

Demo link is unavailable.

image

src/index.html Outdated
</div>
<div class="footer__contact-information">
<h3>Visit us</h3>
<p>2905 West Drive, Buffalo Grove</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be a link for a google maps url

image

color: #253757;
}

&--information{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no hover effect on these elements

image

@@ -0,0 +1,149 @@
.testimonials{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no hover effect on review elemets

image

src/index.html Outdated
</h3>
</article>

<article class="

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation on the entire html document is disrespecting the linting styling from the linting packages provided by Mate.

src/index.html Outdated
<input
type="text"
class="footer__message-input"
placeholder="Your message"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this input should be a textarea.

what if the user wants to send a 30 lines text? It would be very difficult to see the entire text on this small and unresizable field.

src/index.html Outdated
<p>004</p>
</div>
<div class="service__item--jobs">
Digital Communications<br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its perfectly fine to wrap each phrase on html tags to avoid the <br> tag.

src/index.html Outdated
<p>003</p>
</div>
<div class="service__item--jobs">
Marketing Strategy<br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its perfectly fine to wrap each phrase on html tags to avoid the
tag.

src/index.html Outdated
<p>002</p>
</div>
<div class="service__item--jobs">
Сontent Production<br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its perfectly fine to wrap each phrase on html tags to avoid the
tag.

src/index.html Outdated
<p>001</p>
</div>
<div class="service__item--jobs">
Brand Development<br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its perfectly fine to wrap each phrase on html tags to avoid the
tag.

@@ -0,0 +1,14 @@
@import 'utils';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commenting here to not pollute the other scss files.

i don't see any hover and cursor styles across the styling.

image

Copy link

@joaorpereira joaorpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MannyShussan the Header Menu is not opening on mobile screen

border-radius: 8px;
background-color: #2060F6;
color: #fff;
border: 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add:
cursor: pointer
outline: none

property here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants