Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented layout_dia #662

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

implemented layout_dia #662

wants to merge 16 commits into from

Conversation

sheva10barca
Copy link

IvanFesenko
IvanFesenko suggested changes May 22, 2023
View reviewed changes
Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-05-22_15h51_30
remove target attribute for pone field

Design missmatch
2023-05-22_15h52_45

This links should lead to same section as same button from the first section
2023-05-22_15h53_30

Fix styles for autocomplete values
2023-05-22_15h54_42

form should not reload page

@sheva10barca sheva10barca requested a review from IvanFesenko May 22, 2023 14:16
Viktor-Kost
Viktor-Kost suggested changes May 22, 2023
View reviewed changes
Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!)
Nice work!

To improve:

  • apply the same placeholder styles for each input
Screenshot 2023-05-22 at 17 29 40

@sheva10barca sheva10barca requested a review from Viktor-Kost May 22, 2023 15:21
etojeDenys
etojeDenys approved these changes May 22, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@IvanFesenko IvanFesenko Awaiting requested review from IvanFesenko

@Viktor-Kost Viktor-Kost Awaiting requested review from Viktor-Kost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheva10barca @IvanFesenko @etojeDenys @Viktor-Kost