Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the first version of air-layout #767

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

PodvAx
Copy link

@PodvAx PodvAx commented Sep 8, 2023

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome animations. few improvements:

  1. the menu looks strange let's stretch on full-width
Screen.Recording.2023-09-09.at.10.39.42.mov
  1. reset auto-complete styles
image

@PodvAx PodvAx requested a review from etojeDenys September 12, 2023 14:54
Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool!

check submit behavior and prevent it, because now it's reloading page and changing url

@PodvAx PodvAx requested a review from sTorba24 September 12, 2023 22:37
@PodvAx
Copy link
Author

PodvAx commented Sep 12, 2023

I don't know why, but on my local host, all work nice. But when i deployed it, on mobile phone, after submitting the form, it don't want scroll to the top. It scroll to the top of the page, only if there is no anchor in url. I already code, that url cleans on load page, but all in vain. And some browsers may finish with 405 error when submitting the form, although in Safari on my phone and in Chrome all works nice.

Copy link

@DarkMistyRoom DarkMistyRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • don't reload the page on form submitting, just clear the form. check 15 option here

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants