Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #768

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #768

wants to merge 2 commits into from

Conversation

Spec0s
Copy link

@Spec0s Spec0s commented Sep 12, 2023

anastasiia-tilikina
anastasiia-tilikina suggested changes Sep 12, 2023
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Yet we have some issues to fix:

  1. fix padding in header and footer
    image

image

  1. Let's add hover effects on for img in not for entire block here
    image

  2. google maps link should be opened in new tab

  3. these cards should be the same height
    image

  4. lets place nav links a bit lower.
    image

  5. form submitton shouldn't reload page. it should only reset fields.

@Spec0s
Copy link
Author

Spec0s commented Sep 12, 2023

i did not find problem with footer ?

anastasiia-tilikina
anastasiia-tilikina suggested changes Sep 13, 2023
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

footer in figma:
image

your footer:
image

image

same thing with header:
image

image

Screen.Recording.2023-09-13.at.11.36.39.mov

anastasiia-tilikina
anastasiia-tilikina approved these changes Sep 13, 2023
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiia-tilikina anastasiia-tilikina anastasiia-tilikina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spec0s @anastasiia-tilikina