Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout DIA #769

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Layout DIA #769

wants to merge 8 commits into from

Conversation

julwer1k
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 14, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🔥
To improve:

  1. Change this placeholder text to "Your email"
image
  1. Make all these fields are required before click send
image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 14, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add transition for hover effects here
image
  1. It is necessary to correct horizontally
    Demo
image

Design
image

@julwer1k
Copy link
Author

.Changed the ::after logic in the Hire - Us link, it will be displayed in the same way as top-bar nav links

anastasiiavorobiova
anastasiiavorobiova approved these changes Sep 14, 2023
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julwer1k @volodymyr-soltys97 @anastasiiavorobiova