Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new task #777

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

new task #777

wants to merge 10 commits into from

Conversation

Vovchukkul
Copy link

etojeDenys
etojeDenys suggested changes Sep 26, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. should be the button with some hover and cursor: pointer
image
  1. add some hovers
image image
  1. should be links
image
  1. should be the form button
image
  1. disable scroll when menu is open
  2. add favicon

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 27, 2023
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! https://www.loom.com/share/d8edc2aa7d7a4714a6291408482674a9?sid=334e35fc-be2b-4492-8432-d51329544f72 Please, watch my comments here
Screenshot 2023-09-27 at 17 18 28
Screenshot 2023-09-27 at 17 18 35
Screenshot 2023-09-27 at 17 18 54
And try to fix validation errors

etojeDenys
etojeDenys suggested changes Sep 28, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. you should add some container to fix strange behaviour on big screens
image
  1. When you try to send the form there is no 405 error and the form is automatically cleared after submit and is scrolled to the top of the page or the page is reloaded
  2. The form shouldn’t submit empty
  3. When a user clicks on Address Google Maps is opened in a new tab
  4. In the PROCESS section add a hover effect to cards (for example, let them increase in size a little)

src/index.html Outdated
<h1>Dia</h1>
<header class="header">
<div class="top-bar">
<wrap class="wrap">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not fixed comment with wrap

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

maxim2310
maxim2310 suggested changes Sep 29, 2023
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just couple tiny things needs to be fixed before approval)

  1. need to remove autocomplete styles
    image
  2. name and message must be required
  3. would be nice to add hover to these cards also
    image

src/styles/utils/_mixins.scss
Comment on lines +8 to +25
@mixin contentPaddingInline() {
padding-inline: 20px;

@include onTablet {
padding-inline: 41px;
}

@include onDesktop {
padding-inline: 54px;
}

@include onBiggestDesk {
padding-inline: 227px;
}

@include onLargestScreen {
padding-inline: 707px;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier way its set max-width

sTorba24
sTorba24 suggested changes Sep 30, 2023
View reviewed changes
Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. this section isn't centered
    image

  2. set max-width for content inside blocks(you have mock for big screens and content still has such width)
    image

  3. why text is black inside input? it is very inconspicuous
    image

4.remove target _blank from call link
image

src/styles/utils/_mixins.scss
Comment on lines +23 to +25
@include onLargestScreen {
padding-inline: 707px;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's really not good idea :(

@Vovchukkul Vovchukkul requested a review from sTorba24 September 30, 2023 07:50
etojeDenys
etojeDenys suggested changes Sep 30, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. looks broken
image image
  1. these links should lead to some sections
image

etojeDenys
etojeDenys suggested changes Sep 30, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to re-deploy your site, cause nothing changed

etojeDenys
etojeDenys suggested changes Sep 30, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still can reproduce the comments, feel fee to ask for some help in chat

@Vovchukkul
Copy link
Author

  1. looks broken

image image
2. these links should lead to some sections

image

can you explain what the problem is? because I think that the problem is in distance between send button and air block

@Vovchukkul
Copy link
Author

this is how it looks like in my latest pr
image

etojeDenys
etojeDenys approved these changes Sep 30, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@maxim2310 maxim2310 Awaiting requested review from maxim2310

@sTorba24 sTorba24 Awaiting requested review from sTorba24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vovchukkul @sTorba24 @etojeDenys @maxim2310 @anastasiiavorobiova