Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve task, create landing page #784

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

solve task, create landing page #784

wants to merge 6 commits into from

Conversation

Softjey
Copy link

@Softjey Softjey commented Oct 5, 2023

etojeDenys
etojeDenys suggested changes Oct 6, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. looks different from layout
image image

@Softjey Softjey requested a review from etojeDenys October 6, 2023 12:46
VitaliyBodnar
VitaliyBodnar suggested changes Oct 6, 2023
View reviewed changes
Copy link

@VitaliyBodnar VitaliyBodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • menu width should take all screen with
  • page scroll should be disable when menu is opened
Screenshot 2023-10-06 at 15 51 33
  • remove default field styles
Screenshot 2023-10-06 at 15 51 10

@Softjey Softjey requested a review from VitaliyBodnar October 6, 2023 18:26
anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 7, 2023
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful landing!
Screenshot 2023-10-07 at 09 31 39
Screenshot 2023-10-07 at 09 31 46
Screenshot 2023-10-07 at 09 31 54
Screenshot 2023-10-07 at 09 32 02
Screenshot 2023-10-07 at 09 32 09
Consider fixing validation errors
Screenshot 2023-10-07 at 09 34 41
Screenshot 2023-10-07 at 09 34 56
Check indents in the menu for 1024 screen size

etojeDenys
etojeDenys approved these changes Oct 7, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@VitaliyBodnar VitaliyBodnar Awaiting requested review from VitaliyBodnar

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Softjey @VitaliyBodnar @etojeDenys @anastasiiavorobiova