Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add air #798

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add air #798

wants to merge 3 commits into from

Conversation

AntonBelia
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍
Let's improve your code

src/index.html Outdated
Comment on lines 9 to 13
<script
type="text/javascript"
src="scripts/main.js"
defer
></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the indents here

Suggested change
<script
type="text/javascript"
src="scripts/main.js"
defer
></script>
<script
type="text/javascript"
src="scripts/main.js"
defer
></script>

src/index.html Outdated
Comment on lines 432 to 436
<form
action="GET"
class="form"
onsubmit="this.reset(); return false;"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<form
action="GET"
class="form"
onsubmit="this.reset(); return false;"
>
<form
action="GET"
class="form"
onsubmit="this.reset(); return false;"
>

src/index.html Outdated
Comment on lines 468 to 474
<button
href="#"
class="form__button button"
type="submit"
>
Send
</button>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button
href="#"
class="form__button button"
type="submit"
>
Send
</button>
<button
href="#"
class="form__button button"
type="submit"
>
Send
</button>

src/index.html Outdated
Comment on lines 491 to 495
<a
href="tel:654 321 987"
class="contact-us__bottom-about--desc">
654 321 987
</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a
href="tel:654 321 987"
class="contact-us__bottom-about--desc">
654 321 987
</a>
<a
href="tel:654321987"
class="contact-us__bottom-about--desc"
>
654 321 987
</a>

text-align: center;
font-family: $font-family-sun;
font-size: 22px;
font-style: normal;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a default value, you can remove it everywhere

Suggested change
font-style: normal;

color: #fff;
font-family: $font-family-sun;
font-size: 18px;
font-weight: 400;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value, you can remove it

Suggested change
font-weight: 400;

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants