-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add air #798
base: master
Are you sure you want to change the base?
add air #798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍
Let's improve your code
src/index.html
Outdated
<script | ||
type="text/javascript" | ||
src="scripts/main.js" | ||
defer | ||
></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the indents here
<script | |
type="text/javascript" | |
src="scripts/main.js" | |
defer | |
></script> | |
<script | |
type="text/javascript" | |
src="scripts/main.js" | |
defer | |
></script> |
src/index.html
Outdated
<form | ||
action="GET" | ||
class="form" | ||
onsubmit="this.reset(); return false;" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<form | |
action="GET" | |
class="form" | |
onsubmit="this.reset(); return false;" | |
> | |
<form | |
action="GET" | |
class="form" | |
onsubmit="this.reset(); return false;" | |
> |
src/index.html
Outdated
<button | ||
href="#" | ||
class="form__button button" | ||
type="submit" | ||
> | ||
Send | ||
</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<button | |
href="#" | |
class="form__button button" | |
type="submit" | |
> | |
Send | |
</button> | |
<button | |
href="#" | |
class="form__button button" | |
type="submit" | |
> | |
Send | |
</button> |
src/index.html
Outdated
<a | ||
href="tel:654 321 987" | ||
class="contact-us__bottom-about--desc"> | ||
654 321 987 | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a | |
href="tel:654 321 987" | |
class="contact-us__bottom-about--desc"> | |
654 321 987 | |
</a> | |
<a | |
href="tel:654321987" | |
class="contact-us__bottom-about--desc" | |
> | |
654 321 987 | |
</a> |
src/styles/blocks/about-us.scss
Outdated
text-align: center; | ||
font-family: $font-family-sun; | ||
font-size: 22px; | ||
font-style: normal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a default value, you can remove it everywhere
font-style: normal; |
src/styles/blocks/black.scss
Outdated
color: #fff; | ||
font-family: $font-family-sun; | ||
font-size: 18px; | ||
font-weight: 400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value, you can remove it
font-weight: 400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🔥
DEMO LINK.