Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #948

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

add task solution #948

wants to merge 10 commits into from

Conversation

AndriiZakharenko
Copy link

DanilWeda
DanilWeda approved these changes Jun 23, 2024
View reviewed changes
Copy link

@DanilWeda DanilWeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Check some UI moments:

  1. Icon in head tag
    image

  2. Also check font-weight which your use. Maybe I miss something, but I think their have differences.

  3. You can compress photo for better first load.

Final, I checked your code - awesome job!
Thanks you for request. I approved with a small comments.
Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanilWeda DanilWeda DanilWeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriiZakharenko @DanilWeda