Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #957

Closed
wants to merge 1 commit into from
Closed

add task solution #957

wants to merge 1 commit into from

Conversation

MK030191
Copy link

anastasiia-tilikina
anastasiia-tilikina suggested changes Jul 10, 2024
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Things we need to fix:

  1. you need to fix bg image for this section on large screen
    image

  2. Add hover effects on these links
    image

  3. gap here is too big
    figma:

image

your page:
image

  1. disable page scroll when menu is open

anastasiia-tilikina
anastasiia-tilikina suggested changes Jul 10, 2024
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@MK030191 MK030191 closed this by deleting the head repository Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiia-tilikina anastasiia-tilikina anastasiia-tilikina requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MK030191 @anastasiia-tilikina